ts.server.ProjectService.closeConfiguredProject returns true on success.

NaridaL · NaridaL · commit ada1d1e03ce0 · 2017-08-31T16:28:32.000+02:00
Fixes microsoft#17892 The if condition around the return value of that method in closeExternalProject indicates that this was the expected behavior.
diff --git a/src/server/editorServices.ts b/src/server/editorServices.ts
@@ -1686,11 +1686,13 @@ namespace ts.server {
             }
         }
 
-        private closeConfiguredProject(configFile: NormalizedPath): void {
+        private closeConfiguredProject(configFile: NormalizedPath): boolean {
             const configuredProject = this.findConfiguredProjectByProjectName(configFile);
             if (configuredProject && configuredProject.deleteOpenRef() === 0) {
                 this.removeProject(configuredProject);
+                return true;
             }
+            return false;
         }
 
         closeExternalProject(uncheckedFileName: string, suppressRefresh = false): void {

Original file line number	Diff line number	Diff line change
`@@ -1686,11 +1686,13 @@ namespace ts.server {`
`1686`	`1686`	`}`
`1687`	`1687`	`}`
`1688`	`1688`
`1689`		`- private closeConfiguredProject(configFile: NormalizedPath): void {`
	`1689`	`+ private closeConfiguredProject(configFile: NormalizedPath): boolean {`
`1690`	`1690`	`const configuredProject = this.findConfiguredProjectByProjectName(configFile);`
`1691`	`1691`	`if (configuredProject && configuredProject.deleteOpenRef() === 0) {`
`1692`	`1692`	`this.removeProject(configuredProject);`
	`1693`	`+ return true;`
`1693`	`1694`	`}`
	`1695`	`+ return false;`
`1694`	`1696`	`}`
`1695`	`1697`
`1696`	`1698`	`closeExternalProject(uncheckedFileName: string, suppressRefresh = false): void {`