fix($compile): don't add replaced attributes twice to $attrs

Fixes angular#8159

Closes angular#5597

Closes angular#5597

Closes angular#5597

Closes angular#5597

Closes angular#5597

Closes angular#5597

Author: Narretz

src/ng/compile.js

@@ -2761,18 +2761,22 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
 
       // copy the new attributes on the old attrs object
       forEach(src, function(value, key) {
-        if (key === 'class') {
-          safeAddClass($element, value);
-          dst['class'] = (dst['class'] ? dst['class'] + ' ' : '') + value;
-        } else if (key === 'style') {
-          $element.attr('style', $element.attr('style') + ';' + value);
-          dst['style'] = (dst['style'] ? dst['style'] + ';' : '') + value;
-          // `dst` will never contain hasOwnProperty as DOM parser won't let it.
-          // You will get an "InvalidCharacterError: DOM Exception 5" error if you
-          // have an attribute like "has-own-property" or "data-has-own-property", etc.
-        } else if (key.charAt(0) !== '$' && !dst.hasOwnProperty(key)) {
-          dst[key] = value;
-          dstAttr[key] = srcAttr[key];
+        // Check if we already set this attribute in the loop above
+        if (!dst[key]) {
+
+          if (key === 'class') {
+            safeAddClass($element, value);
+            dst['class'] = (dst['class']   ? dst['class'] + ' ' : '') + value;
+          } else if (key === 'style') {
+            $element.attr('style', $element.attr('style') + ';' + value);
+            dst['style'] = (dst['style'] ? dst['style'] + ';' : '') + value;
+            // `dst` will never contain hasOwnProperty as DOM parser won't let it.
+            // You will get an "InvalidCharacterError: DOM Exception 5" error if you
+            // have an attribute like "has-own-property" or "data-has-own-property", etc.
+          } else if (key.charAt(0) !== '$' && !dst.hasOwnProperty(key)) {
+            dst[key] = value;
+            dstAttr[key] = srcAttr[key];
+          }
         }
       });
     }

test/ng/compileSpec.js

@@ -980,6 +980,32 @@ describe('$compile', function() {
         }));
 
 
+
+
+        it('should not set merged attributes twice in $attrs', function() {
+          var attrs;
+
+          module(function() {
+            directive('logAttrs', function() {
+              return {
+                link: function($scope, $element, $attrs) {
+                  attrs = $attrs;
+                }
+              }
+            })
+          });
+
+          inject(function($compile, $rootScope) {
+            element = $compile(
+              '<div><div log-attrs replace class="myLog"></div><div>')($rootScope);
+            var div = element.find('div');
+            expect(div.attr('class')).toBe('myLog log');
+            console.log('attrs', attrs.class);
+            expect(attrs.class).toBe('myLog log');
+          });
+        });
+
+
         it('should prevent multiple templates per element', inject(function($compile) {
           try {
             $compile('<div><span replace class="replace"></span></div>');