Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DataColumnSidecar validator checks according to the spec #158

Open
zilm13 opened this issue Oct 3, 2024 · 0 comments
Open

Update DataColumnSidecar validator checks according to the spec #158

zilm13 opened this issue Oct 3, 2024 · 0 comments

Comments

@zilm13
Copy link
Collaborator

zilm13 commented Oct 3, 2024 •
edited
Loading

Following changes are proposed: ethereum/consensus-specs#3953
The difference between what we have is following:

  1. index < number of columns is separate check in validator
  2. columns == proofs == commitments check is inside kzgProof check
  3. non zero commitments check is inside inclusionProofCheck

We should arrange this checks to looks similar to the spec, so it will be easy to follow the changes and maintain them in the future.
@zilm13 zilm13 changed the title Update DataColumnSidecar checks according to the spec Update DataColumnSidecar validator checks according to the spec Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zilm13