Skip to content

Fix incompatible ScheduleTypeLimits issue for CoilCoolingWaterPanelRadiant cooling control temperature schedule #5596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joseph-robertson wants to merge 6 commits into
base: develop
Choose a base branch
from
+41 −2
Open

Fix incompatible ScheduleTypeLimits issue for CoilCoolingWaterPanelRadiant cooling control temperature schedule #5596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c2e4891
Add radiant panel model test to demonstrate schedule type limits issue.
joseph-robertson Jan 27, 2026
08449e1
Formatting.
joseph-robertson Jan 27, 2026
7451305
Typo in new test.
joseph-robertson Jan 27, 2026
958b1ba
Update ScheduleTypeRegistry.cpp for cooling panel temperature schedule.
joseph-robertson Jan 27, 2026
eec4177
Formatting.
joseph-robertson Jan 29, 2026
5a2f391
Updates for schedule type keys.
joseph-robertson Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/model/CoilCoolingWaterPanelRadiant.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,17 @@ namespace model {
return CoilCoolingWaterPanelRadiant::iddObjectType();
}

std::vector<ScheduleTypeKey> CoilCoolingWaterPanelRadiant_Impl::getScheduleTypeKeys(const Schedule& schedule) const {
std::vector<ScheduleTypeKey> result;
UnsignedVector fieldIndices = getSourceIndices(schedule.handle());
UnsignedVector::const_iterator b(fieldIndices.begin());
UnsignedVector::const_iterator e(fieldIndices.end());
if (std::find(b, e, OS_Coil_Cooling_Water_Panel_RadiantFields::CoolingControlTemperatureScheduleName) != e) {
result.push_back(ScheduleTypeKey("CoilCoolingWaterPanelRadiant", "Cooling Control Temperature Schedule"));
}
return result;
}

unsigned CoilCoolingWaterPanelRadiant_Impl::inletPort() const {
return OS_Coil_Cooling_Water_Panel_RadiantFields::WaterInletNodeName;
}
Expand Down Expand Up @@ -252,7 +263,7 @@ namespace model {

bool CoilCoolingWaterPanelRadiant_Impl::setCoolingControlTemperatureSchedule(Schedule& coolingControlTemperatureSchedule) {
bool result = setSchedule(OS_Coil_Cooling_Water_Panel_RadiantFields::CoolingControlTemperatureScheduleName, "CoilCoolingWaterPanelRadiant",
"Cooling Control Temperature", coolingControlTemperatureSchedule);
"Cooling Control Temperature Schedule", coolingControlTemperatureSchedule);
return result;
}

Expand Down
2 changes: 2 additions & 0 deletions src/model/CoilCoolingWaterPanelRadiant.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ namespace openstudio {

namespace model {

class Schedule;

namespace detail {

class CoilCoolingWaterPanelRadiant_Impl;
Expand Down
4 changes: 4 additions & 0 deletions src/model/CoilCoolingWaterPanelRadiant_Impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
namespace openstudio {
namespace model {

class Schedule;

namespace detail {

/** CoilCoolingWaterPanelRadiant_Impl is a StraightComponent_Impl that is the implementation class for CoilCoolingWaterPanelRadiant.*/
Expand All @@ -39,6 +41,8 @@ namespace model {

virtual IddObjectType iddObjectType() const override;

virtual std::vector<ScheduleTypeKey> getScheduleTypeKeys(const Schedule& schedule) const override;

virtual unsigned inletPort() const override;

virtual unsigned outletPort() const override;
Expand Down
3 changes: 2 additions & 1 deletion src/model/ScheduleTypeRegistry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,8 @@ namespace model {
{"CoilCoolingLowTempRadiantVarFlow", "Cooling Control Temperature Schedule", "coolingControlTemperatureSchedule", true, "Temperature",
OptionalDouble(), OptionalDouble()},
{"CoilCoolingWater", "Availability", "availabilitySchedule", false, "Availability", 0.0, 1.0},
{"CoilCoolingWaterPanelRadiant", "Cooling Control Temperature", "coolingControlTemperatureSchedule", true, "", 0.0, OptionalDouble()},
{"CoilCoolingWaterPanelRadiant", "Cooling Control Temperature Schedule", "coolingControlTemperatureSchedule", true, "Temperature",
OptionalDouble(), OptionalDouble()},
Comment on lines +210 to +211
Copy link
Collaborator Author

@joseph-robertson joseph-robertson Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix, right here.

{"CoilCoolingWaterToAirHeatPumpEquationFit", "Availability Schedule", "availabilitySchedule", false, "Availability", 0.0, 1.0},
{"CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit", "Availability Schedule", "availabilitySchedule", false, "Availability", 0.0, 1.0},
{"CoilHeatingDesuperheater", "Availability", "availabilitySchedule", false, "Availability", 0.0, 1.0},
Expand Down
21 changes: 21 additions & 0 deletions src/model/test/CoilCoolingWaterPanelRadiant_GTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
#include "../ScheduleConstant_Impl.hpp"
#include "../AirLoopHVAC.hpp"
#include "../AirLoopHVACZoneSplitter.hpp"
#include "../ScheduleRuleset.hpp"
#include "../ScheduleTypeLimits.hpp"

using namespace openstudio;
using namespace openstudio::model;
Expand Down Expand Up @@ -111,3 +113,22 @@ TEST_F(ModelFixture, CoilCoolingWaterPanelRadiant_SetGetFields) {
coil.resetCoolingControlTemperatureSchedule();
EXPECT_FALSE(coil.coolingControlTemperatureSchedule());
}

TEST_F(ModelFixture, CoilCoolingWaterPanelRadiant_CoolingControlTemperatureSchedule) {
// Address #5595, "CoilCoolingWaterPanelRadiant.setCoolingControlTemperatureSchedule" but
// keep getting 'incompatible ScheduleTypeLimits' error.

Model m;
CoilCoolingWaterPanelRadiant coil(m);

ScheduleTypeLimits temperatureLimits(m);
EXPECT_TRUE(temperatureLimits.setLowerLimitValue(-60));
EXPECT_TRUE(temperatureLimits.setUpperLimitValue(200));
EXPECT_TRUE(temperatureLimits.setNumericType("Continuous"));
EXPECT_TRUE(temperatureLimits.setUnitType("Temperature"));

ScheduleRuleset temperatureSchedule(m);
EXPECT_TRUE(temperatureSchedule.setScheduleTypeLimits(temperatureLimits));

EXPECT_TRUE(coil.setCoolingControlTemperatureSchedule(temperatureSchedule));
}
Loading