-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin Flask and rdflib major/minor versions #697
Comments
Also the versions of system packages for Voikko in the Docker image could be pinned. Current ones are the following:
|
In branch update-dependencies-v1.0 Flask is pinned to 2.2.* instead of newer 2.3.* due to the requirement by Connexion v2.14.2. Changing pinning of rdflib from
Which is strange. I think it is better to not touch this line, to avoid the downgrades. (Updating rdflib to 7.* is blocked by the requirement by stwfsapy.) |
How about pinning rdflib to |
Yes, that is the right pinning ofcourse. And using it does not downgrade urllib3. |
@osma Any opinion on pinning the system packages? Some Debian versions use different voikko package versions / version numbers: Now I think pinning system packages is not necessary. |
In my understanding, choosing a specific Debian stable release (e.g. bookworm) in practice pins the voikko/libvoikko versions into a very narrow range. Only serious bugs will be fixed by Debian, and if that happens, we probably want to upgrade to the updated versions. So I don't think pinning on that level is necessary. |
Currently Flask and rdflib are loosely pinned in pyproject.toml:
I meant to pin all major/minor versions of all non-dev dependencies as suggested in #683, but missed these two.
Lets do it for the next release, however wait for connexion 3 release, as the current connexion version 2.14 dependens on not-latests Flask version.
The text was updated successfully, but these errors were encountered: