Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept-specific REST method groupMembers is missing an URI parameter in the swagger documentation #1333

Closed
joelit opened this issue Jun 6, 2022 · 3 comments
Labels
Milestone

Comments

@joelit
Copy link
Contributor

joelit commented Jun 6, 2022

At which URL did you encounter the problem?

https://api.finto.fi/doc/#!/Concept45specific32methods/get_vocid_groupMembers

What steps will reproduce the problem?

  1. Try to send a request to the REST API using the swagger interactive documentation
  2. You can fill in the vocab id and the request language, but no concept uri
  3. The result https://api.finto.fi/rest/v1/yso/groupMembers?lang=fi will always be empty list

What is the expected output? What do you see instead?

When querying the group members for a concept group, the uri of the concept group should be one of the parameters

What browser did you use? (eg. Firefox, Chrome, Safari, Internet explorer)

Chromium

@joelit joelit added the REST label Jun 6, 2022
@joelit joelit modified the milestones: Next Tasks, No further action Jun 6, 2022
@joelit
Copy link
Contributor Author

joelit commented Jun 6, 2022

Ninja'ed by @danmichaelo in #1332 😃

@joelit joelit closed this as completed Jun 6, 2022
@osma
Copy link
Member

osma commented Jun 6, 2022

A bit premature to close this when the PR is still unmerged?

@osma
Copy link
Member

osma commented Jun 23, 2022

Ah, the PR was actually created just before this issue was opened. Anyway, the PR is now merged and there is no need to reopen this issue as the problem has been solved.

@osma osma modified the milestones: No further action, 2.16 Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants