Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress tests for partial page load #1598

Closed
3 tasks done
osma opened this issue Mar 5, 2024 · 0 comments · Fixed by #1605
Closed
3 tasks done

Cypress tests for partial page load #1598

osma opened this issue Mar 5, 2024 · 0 comments · Fixed by #1605

Comments

@osma
Copy link
Member

osma commented Mar 5, 2024

Description of the enhancement

Add Cypress tests for the already existing partial page load functionality. The sidebar components (alphabetical, hierarchy) already support this (clicking on concepts in either of these performs a partial page load of the concept information) but current Cypress test do not verify that all functionality is working after partial page loads.

Initial TODO:

  • Ensure that there are Cypress tests for partial page loads in all situations where this happens (all page types that show a sidebar)
  • The old draft PR Add cypress tests for partial page load on vocab home page #1474 by @UnniKohonen contains proposed Cypress tests for partial page load; see if it can be reused, or close it if it cannot.
  • Adjust the Cypress tests for the concept page; make sure they verify functionality both with and without partial page loads (perhaps using dynamic tests; each test should be executed twice - with and without partial page load)

Who are the users that would benefit from the enhancement and how?

Skosmos developers. It's easy to forget testing after partial page loads.

What new functionalities would the enhancement make possible?

Ensure that functionality is not broken by accident.

Why is the enhancement important?

Breakage after partial page loads has happened several times in recent development sprints, so the problem is urgent.

@osma osma added this to the 3.0 milestone Mar 5, 2024
@joelit joelit moved this to Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR) in Skosmos 3.0 Backlog Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging a pull request may close this issue.

1 participant