Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On concept page, ordering of narrower concepts is not correct wrt accented characters #679

Closed
tfrancart opened this issue Jan 5, 2018 · 2 comments
Labels
Milestone

Comments

@tfrancart
Copy link
Contributor

tfrancart commented Jan 5, 2018

At which URL did you encounter the problem?

http://erato.sparna.fr/scolomfr/scolomfr-voc-000-3-2/fr/page/?uri=http%3A%2F%2Fdata.education.fr%2Fvoc%2Fscolomfr%2Fconcept%2Fscolomfr-voc-015-num-099

What steps will reproduce the problem?

  1. Go to above URL
  2. In the narrowers section, narrowers starting with "é" are at the end of the list

What is the expected output? What do you see instead?

narrowers starting with "é" should be placed after narrower starting with "e".

In ConceptProperty::sortValues(), strcoll should be used instead of strnatcasecmp in combination with lowercasing to have case-insensitive + locale-based ordering.

PR to follow.

@tfrancart tfrancart mentioned this issue Jan 5, 2018
@osma osma added the bug label Jan 30, 2018
@henriyli henriyli added this to the 2.0 milestone Jan 30, 2018
@osma
Copy link
Member

osma commented Feb 8, 2018

This caused a regression in PTVL. Previously the classes (concepts) in the classification were ordered numerically by notation code, e.g. P1 comes first and P10 comes after P9:
http://finto.fi/ptvl/fi/page/?uri=http://urn.fi/URN:NBN:fi:au:ptvl:

But after this fix, P10 comes first and P1 is after P19:
http://dev.finto.fi/ptvl/fi/page/?uri=http://urn.fi/URN:NBN:fi:au:ptvl:

I'm not sure if it's possible to do a correct sort in both cases (accented characters + natural sort for numbers).

@osma
Copy link
Member

osma commented Mar 12, 2018

I made a separate issue for the PTVL problem, so this one can be closed.

@osma osma closed this as completed Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants