New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump PHP version #917

Closed

osma opened this issue Jan 31, 2020 · 0 comments · Fixed by #919

Assignees

Labels

enhancement php7 size-small tests

Milestone

Member

osma commented Jan 31, 2020 •

edited

Loading

Currently Skosmos requires 7.0 and supports versions 7.1 and 7.2. But PHP 7.3 and 7.4 have been available for some time. I suggest the following:

drop support for PHP 7.0 (this would enable using more advanced parameter type hints introduced in 7.1 - but actually doing that is out of scope for this issue)
try to run Skosmos under PHP 7.3 and 7.4
enable running Travis CI tests under 7.3 and 7.4 (with allowed_failures set to true if they cannot be run succesfully already)
open separate issues for any problems found with 7.3 and 7.4

osma added enhancement tests php7 labels

osma added this to the Next Tasks milestone

osma added the size-small label

osma self-assigned this

osma mentioned this issue

Upgrade to PHP 7.1-7.4 and Fuseki 3.14.0 #919

Merged

kouralex closed this as completed in #919

kouralex modified the milestones: Next Tasks, 2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment