Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need for a static version number in the project #965

Closed
joelit opened this issue Apr 2, 2020 · 2 comments
Closed

Need for a static version number in the project #965

joelit opened this issue Apr 2, 2020 · 2 comments
Milestone

Comments

@joelit
Copy link
Contributor

joelit commented Apr 2, 2020

Currently, Skosmos generates the version information for the about page with git describe. This has the problem that it's assumed Skosmos is always deployed in an initialized git repository, otherwise the version is displayed as 'unknown'.

The version information could be stored in a separate file in a static manner, that is kept up to date with a git pre-commit hook. This way the version tag could be displayed no matter how Skosmos is deployed.

@kinow
Copy link
Collaborator

kinow commented Apr 2, 2020

We had a similar problem in a project I am currently working on. The version would come from a Python file, then the git tag or commit would be appended. But if you deployed it without the git information it would fail.

Now it's only in Python, the same place where we get the value used in setup.py and uploaded to PYPI.

It also got a new frontend, in JS. The version is in the package.json file, and should match the tag once released. In the UI, there is a fixed place where we display the UI version too, which is useful when comparing screenshots or deploying a new version.

+1

@osma
Copy link
Member

osma commented Oct 10, 2022

This was implemented in PR #1308 released as part of Skosmos 2.15, but we forgot to close this issue.

@osma osma closed this as completed Oct 10, 2022
@osma osma added this to the 2.15 milestone Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants