Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "emits" and propagation of events in circle and rectangle #53

Closed
oliverkirsch opened this issue Feb 19, 2023 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@oliverkirsch
Copy link

Hi everyone,
further "playing" with this project, I stumbled upon a warning regarding a missing "emits" for the circle component. When adding this option for a test, it lacked propagation.

As far as I could see this issue also affects the rectangle component.

If I understood everything correctly, adding emits: events to the export and using the afterCreate hook used in other components to register and actively emit events should do the trick, see here:
1e1222f

Thanks for looking into this!

@NathanAP
Copy link
Owner

Hello! Thanks for your help!

Can you add this to a PR? It will be easier for people help you improve and test it :)

You need to create a new branch inside the project, make your commits and then open a PR.

@NathanAP NathanAP self-assigned this Feb 20, 2023
@NathanAP NathanAP added the bug Something isn't working label Feb 20, 2023
@oliverkirsch
Copy link
Author

Hi Nathan and thank you! I screwed up with my first attempt, but now I got it and there's PR #54 :)

@NathanAP
Copy link
Owner

#54 is now merged, so I'm closing this one :) Let me know if there is something else related to this and I'll open again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants