Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify color/font configuration #1785

Closed
ubitux opened this issue Apr 17, 2020 · 4 comments
Closed

Unify color/font configuration #1785

ubitux opened this issue Apr 17, 2020 · 4 comments
Labels
Reason: OBE This has been "overcome by events."

Comments

@ubitux
Copy link

ubitux commented Apr 17, 2020

The way Ghidra opens ways of customizing the interface is currently far from ideal, and it's very tricky to get a consistent view in the whole tool.

In the details, as of 9.1.2, here are all the menus where we have to set the font:

  • Console
  • DecompilerDisplay
  • Listing Display (done differently than the others, size control typically has a different granularity)

And here are where we have to set the colors:

  • ByteViewer
  • DecompilerDisplay
  • Entropy
  • Function graph
  • Listing Display (done differently than the others, more advanced)
  • Listing Fields → {Cursor, Cursor Text Highlight, Selection Colors}
  • Overview
  • Search

A better solution I would see would be to first have a common view for all the available color and font customizations. Then presets (or palettes of colors) could be added easily. The remaining UI widgets can be stylized through the engine itself (typically by picking GTK+).

All the different views of the UI would use these shared color and font settings instead of their own: there is no reason someone would wish for an inconsistent experience between the different view.

@astrelsky
Copy link
Contributor

If there isn't a hidden "common view"/global font color, style, etc setting somewhere then I highly agree. While it is nice to be able to customize things individually it should always be possible to choose the default behavior.

@saruman9
Copy link
Contributor

BTW, many colors are hard-coded and can't be changed ever from the options menu (issues, for example: #49, #1324, #632, #1390, etc). I rewrote many such places in the source code for changing colors to a dark, but I’m sure that there are still hard-coded places.

Relates to issue #13. Ghidra's developers have in plans to unify settings of UI and create theme manager.

@pabx06
Copy link

pabx06 commented Oct 2, 2020

some time it is as easy as to comment a line:
https://github.com/pabx06/buildghidra/blob/8c75127ec14aaf9dadc963d9dfa8cc99ae24fff1/patch/InfoPanel.patch#L27
so the default applied look and feel do the coloring.
image

@dragonmacher
Copy link
Collaborator

You can now change most application colors, icons and fonts by editing the current Theme.

Fixed by e657a70

@dragonmacher dragonmacher added the Reason: OBE This has been "overcome by events." label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reason: OBE This has been "overcome by events."
Projects
None yet
Development

No branches or pull requests

5 participants