Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function Call Trees: Keep indentation of copied Outgoing Calls #7417

Closed
gemesa opened this issue Jan 25, 2025 · 3 comments
Closed

Function Call Trees: Keep indentation of copied Outgoing Calls #7417

gemesa opened this issue Jan 25, 2025 · 3 comments
Assignees
Labels
Status: Internal This is being tracked internally by the Ghidra team
Milestone

Comments

@gemesa
Copy link
Contributor

gemesa commented Jan 25, 2025

Is your feature request related to a problem? Please describe.

When opening Window --> Function Call Trees and copying Outgoing Calls, the indentation is not preserved:

Image

After selecting all then copying and pasting:

Outgoing References - mw_handle_http_request
mw_memset
InternetCrackUrlA
mw_open_connection
InternetOpenA
InternetConnectA
HttpOpenRequestA
InternetCloseHandle
InternetQueryOptionA
InternetSetOptionA
HttpSendRequestA
HttpQueryInfoA
InternetReadFile

Describe the solution you'd like
The following structure (or similar) is copied:

Outgoing References - mw_handle_http_request
mw_memset
InternetCrackUrlA
mw_open_connection
    InternetOpenA
InternetConnectA
HttpOpenRequestA
InternetCloseHandle
InternetQueryOptionA
InternetSetOptionA
HttpSendRequestA
HttpQueryInfoA
InternetReadFile

Describe alternatives you've considered
I implemented a ghidra script for this purpose.

Additional context
N/A

@dragonmacher dragonmacher self-assigned this Jan 27, 2025
@dragonmacher dragonmacher added Status: Triage Information is being gathered Status: Internal This is being tracked internally by the Ghidra team and removed Status: Triage Information is being gathered labels Jan 27, 2025
@ryanmkurtz ryanmkurtz added this to the 11.4 milestone Feb 3, 2025
@gemesa
Copy link
Contributor Author

gemesa commented Feb 4, 2025

The behavior is still the same for me after the commit that is meant to fix this. Am I missing something? Im just clicking into Outgoing Calls, hitting Ctrl+A and copying and pasting it but there is still no indentation.

@dragonmacher
Copy link
Collaborator

dragonmacher commented Feb 4, 2025

The fix was to add a new right-click popup action. Ctrl-A still functions as it did previously. Now you should have a popup action to Copy Formatted.

You can assign a keybinding to this action (but you cannot use Ctrl-A in this case, for this tree).

@gemesa
Copy link
Contributor Author

gemesa commented Feb 4, 2025

It is awesome. Thanks for adding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Internal This is being tracked internally by the Ghidra team
Projects
None yet
Development

No branches or pull requests

3 participants