Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modals): application activityBackPressed event not fired for modals #6261

Merged
merged 1 commit into from
Sep 13, 2018

Conversation

vakrilov
Copy link
Contributor

What is the current behavior?

application.android.on("activityBackPressed", () => { ... }) event is not fired when pressing the back button while showing modal.

What is the new behavior?

The event is now fired and can be canceled.

Resolves #3908

cc @SvetoslavTsenov Test page added in e2e\modal-navigation app -> Android Back Btn Events button

@ghost ghost assigned vakrilov Sep 12, 2018
@ghost ghost added the in progress label Sep 12, 2018
@vakrilov vakrilov changed the base branch from master to release September 12, 2018 13:39
@dtopuzov dtopuzov merged commit 13d4f34 into release Sep 13, 2018
@ghost ghost removed the in progress label Sep 13, 2018
@vakrilov vakrilov deleted the android-modal-back branch September 13, 2018 13:53
@lock
Copy link

lock bot commented Sep 13, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants