feat(scrollview): add isScrollEnabled property #6640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
test branch_tns_core_modules_widgets#mdonev/disable-scroll |
manoldonev
requested review from
ADjenkov,
MartoYankov,
vakrilov and
vchimev
MartoYankov
changed the title
MartoYankov
added
the
docs needed
MartoYankov
approved these changes
Nov 30, 2018
tsonevn
removed
the
docs needed
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ScrollView.isScrollEnabled property that should cover the majority of the scenarios that users try to address with isUserInteractionEnabled / isEnabled properties. This is a straightforward and consistent solution that does one thing and one thing only -- enable/disable scroll.
We have a known inconsistency in Android / iOS with respect to the
isUserInteractionEnabledproperty and container components (e.g. scrollview, various layouts, etc.)-- in iOS when property is set to false on the container, it disables user interaction recursively on all subviews, while on Android it doesn't. As this is the standard behavior on each OS we decided not to streamline this:isUserInteractionEnabledfalse is basically equivalent toisScrollEnabledfalse (if we were to streamline the behavior for scrollview to match iOS counterpart, we would have to do the same for all layout containers too so for the time being we are "consistently inconsistent" -- consistent among Android components and inconsistent betwen Android and iOS)isUserInteractionEnabledfalse disables scroll and also disables user interaction for all subviews.Also, ScrollView.isEnabled property currently has no effect neither on Android, nor on iOS.
Fixes #6511
Depends on NativeScript/tns-core-modules-widgets#150 (merge after the widgets PR)