-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit the "assert" routine in the JNI part #221
Comments
This issue breaks https://github.com/chaijs/chai/blob/master/chai.js
Instead of entering the catch, the runtime crashes with |
This was referenced Oct 15, 2015
Another one reported by @tailsu
In short, the app crashes if it cannot compile the module JavaScript; it should not |
slavchev
pushed a commit
that referenced
this issue
Nov 6, 2015
slavchev
pushed a commit
that referenced
this issue
Nov 6, 2015
slavchev
pushed a commit
that referenced
this issue
Nov 6, 2015
slavchev
pushed a commit
that referenced
this issue
Nov 6, 2015
slavchev
pushed a commit
that referenced
this issue
Nov 6, 2015
slavchev
pushed a commit
that referenced
this issue
Nov 6, 2015
slavchev
pushed a commit
that referenced
this issue
Nov 6, 2015
linked to #277 |
Plamen5kov
added a commit
that referenced
this issue
Nov 27, 2015
slavchev
pushed a commit
that referenced
this issue
Nov 27, 2015
slavchev
pushed a commit
that referenced
this issue
Dec 12, 2015
slavchev
pushed a commit
that referenced
this issue
Dec 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At many places within the C++ code we use either the native assert or the ASSERT_XXX macro. We need to revisit the implementation like so:
Refers to #180 & #196
The text was updated successfully, but these errors were encountered: