Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) metadata crash on startup with Local Notification plugin. #1621

Merged
merged 2 commits into from
Jun 27, 2020

Conversation

NathanaelA
Copy link
Contributor

Description

Android 9 & 10 on some phones now enforce the requirement that after a reboot the data is un-accessible until phone has been unlocked once after startup. According to the docs; this was a new feature in Android 7; but we are only seeing crashes in Android 9 and later.

The new error code detects this specific condition and now just exits the application w/o throwing an error, as throwing an error shows up as a error in the Google application error log. After much testing, exiting the app is the safest course of action with no issues because application doesn't actually need to run at this point.

Does your commit message include the wording below to reference a specific issue in this repo?

Fixes #1546

Does your pull request have [unit tests]

No, unable to test except manually (see #1546 for instructions)

@cla-bot cla-bot bot added the cla: yes label Jun 21, 2020
@shiv19
Copy link
Member

shiv19 commented Jun 21, 2020

test

@NathanaelA NathanaelA merged commit 18c896c into master Jun 27, 2020
@NathanaelA NathanaelA deleted the fix_metadata_crash branch June 27, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

com.tns.NativeScriptException - MetaData cannot be opened.
3 participants