Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): cleaning firebase-messaging-core iOS build warnings #251

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

gabrielbiga
Copy link
Contributor

UNNotificationPresentationOptions.alert is deprecated since iOS 14.0. This commit aims to fix this following the official documentation.

Deprecated
Use list and banner instead.

https://developer.apple.com/documentation/usernotifications/unnotificationpresentationoptions/alert

@cla-bot cla-bot bot added the cla: yes label Apr 4, 2024
@triniwiz
Copy link
Member

triniwiz commented Apr 9, 2024

Alert should still be used for older APIs not removed

@gabrielbiga gabrielbiga force-pushed the fix/fcm-ios-warnings branch from 09661d7 to 25f7bf9 Compare April 10, 2024 15:27
@gabrielbiga
Copy link
Contributor Author

Hello @triniwiz, good catch.
Please take a look again, now its taking care of old platforms and still get rid of the warning.

@triniwiz
Copy link
Member

Perfect 👌🏽

@triniwiz triniwiz merged commit 872c1c2 into NativeScript:main Apr 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants