Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Findings for 3.0.alpha #66

Open
cjohn001 opened this issue Oct 17, 2024 · 0 comments
Open

Findings for 3.0.alpha #66

cjohn001 opened this issue Oct 17, 2024 · 0 comments

Comments

@cjohn001
Copy link

With 3.0 alpha I am seeing a couple of issues:

  1. in mlkit/dist/packages/mlkit-core: run "npm pack" to create a package does not work. The problem is that "angular/package.json" is not included in the .tgz file.
    Solution: Add the following to mlkit-core/package.json
"files": [
    "*",
    "angular/package.json"
  ],

I will provide a patch soon

  1. I can build version 3 of the plugin via command line using ns. However, when openening the created xcode workspace with xcode I am seeing linker errors, see image. I observed the issue also with the old version of the plugin and assume it is related to new ios sdk:
Bildschirmfoto 2024-10-17 um 16 49 01

The solution is to upgrade the pod files to the recent GooleMLKit version:

Bildschirmfoto 2024-10-17 um 16 50 10

I will provide a patch soon

  1. With ios 18 it seems like behaviour of the camera has changed. I observed the issue also with the old version of the plugin. It seems like on ios 18 now automatic focus is deactivated by default. Would be great if an option could be provided to enable autofocus and to enable it by default. This would reflect old behaviour of the plugin . The issue can be observed by comparing autofocus behavior with the demoapp in the plugin and by using the iPhone camera app.

I do not have a solution for issue 3 yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant