Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: page navigation bug if there's not outlet for frame after cleari… #2233

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Conversation

bellalMohamed
Copy link
Contributor

Fix for #2232

@cla-bot
Copy link

cla-bot bot commented Aug 25, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @bellalMohamed.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@bellalMohamed
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Aug 26, 2020
@cla-bot
Copy link

cla-bot bot commented Aug 26, 2020

The cla-bot has been summoned, and re-checked this pull request!

@NathanWalker NathanWalker merged commit 8bedc2d into NativeScript:master Aug 27, 2020
@NathanWalker
Copy link
Contributor

Thank you @bellalMohamed !! we'll publish a patch out with this on thursday ❤️

@NathanWalker
Copy link
Contributor

@bellalMohamed published in 10.0.3 now, thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants