Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two plugins depend on different versions of the same dependency #3354

Open
Plamen5kov opened this issue Feb 7, 2018 · 3 comments
Open

Two plugins depend on different versions of the same dependency #3354

Plamen5kov opened this issue Feb 7, 2018 · 3 comments
Labels
bug build Describes issues related to build operations os: android to-be-checked Issues that might be resolved in a previous release and need to be tested or clarified further

Comments

@Plamen5kov
Copy link
Contributor

Plamen5kov commented Feb 7, 2018

Did you verify this is a real problem by searching the NativeScript Forum and the other open issues in this repo?

Yes

Tell us about the problem

When a native-plugin "A" is added that depends on a specific version of native-dependency... "C". And another native plugin "B" depends on a different version of the native-dependency "C" cli neads to call ./gradlew clean before running build.

Which platform(s) does your issue occur on?

iOS/Android/Both
Android

Please provide the following version numbers that your issue occurs with:

  • CLI: 3.4.0 + next
  • Cross-platform modules: not relevant
  • Runtime(s): 3.4.0 + next
  • Plugin(s):
  • plugin "A"(geolocation) - depends on native-dependency "C" (googlePlayServices version X)
  • plugin "B"(firebase) - depends on native-dependency "C" (googlePlayServices version Y)

Please tell us how to recreate the issue in as much detail as possible.

  • add geolocation plugin
  • tns run android
  • add firebase plugin
  • tns run build (runtime fail, when you try to use geolocation functionality)
@petekanev
Copy link
Contributor

@Plamen5kov how would CLI know what a plugin's dependencies are? I think this resolution is best left to the android runtime build script to handle.

@Plamen5kov
Copy link
Contributor Author

@Pip3r4o the CLI would know that when someone does tns plugin add native-plugin-name it would have to do gradlew clean before building.

@chrillewoodz
Copy link

Any status on this?

@rosen-vladimirov rosen-vladimirov added os: android build Describes issues related to build operations to-be-checked Issues that might be resolved in a previous release and need to be tested or clarified further labels May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug build Describes issues related to build operations os: android to-be-checked Issues that might be resolved in a previous release and need to be tested or clarified further
Projects
None yet
Development

No branches or pull requests

4 participants