fix(publish): Various apple publish/sign in fixes. #5718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also support simple case of single phone registered for sms verification.
jcassidyav
changed the title
rigor789
approved these changes
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Currently any command that tries to login to apple with a username/passwrod will fail and lock the apple account.
e.g.
ns publish ios. fastlane issue: fastlane/fastlane#21071.Current implementation does not support SMS verification. (#5714)
On Xcode >= 14 publish will fail because of the removal of iTMSTransporter. (#5704)
What is the new behavior?
The Hashcash header is implemented allowing login.
The simple 1 phone registered SMS case is supported.
Now uses altool to push ipa if xcode>=14.
fixes #5714
fixes #5704.