Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: interactive typings generation for android #5798

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

rigor789
Copy link
Member

PR Checklist

What is the current behavior?

You have to manually pass in the full path of the aar/jar files via --aar/--jar.

What is the new behavior?

A new interactive menu for picking the aar/jar files based on a glob pattern provided as an argument:

ns typings android "androidx.media3:media3-*"
# or
ns typings android "androidx.media3:media3-*:1.3.1"

Note: the argument needs to be enclosed in quotes as otherwise your shell might try to expand the globs and fail.

Demo:

Screen.Recording.2024-04-11.at.4.36.16.PM.mov

@cla-bot cla-bot bot added the cla: yes label Apr 11, 2024
@rigor789 rigor789 merged commit d3f2e70 into main Apr 16, 2024
1 check passed
@rigor789 rigor789 deleted the feat/interactive-typings-android branch April 16, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant