Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nativescript: do not always use --log trace #129

Open
dtopuzov opened this issue Apr 16, 2019 · 2 comments
Open

nativescript: do not always use --log trace #129

dtopuzov opened this issue Apr 16, 2019 · 2 comments
Assignees
@endarova

Comments

@dtopuzov
Copy link
Contributor

In a lot of cases when we need more detailed log we use --log trace in tests.
This makes tests a bit slower, make console out large and so on.
We also do not test other logging levels at all.

Suggestion:
Now we have boolean log_trace param in all methods.
Make it log_level and make it enum.
@dtopuzov dtopuzov changed the title Do not always use --log trace if we can use other log levels nativescript: do not always use --log trace Apr 16, 2019
@miroslavaivanova miroslavaivanova self-assigned this Apr 17, 2019
@rosen-vladimirov
Copy link
Contributor

We need to remove it from preview tests - we can use --link instead of passing --log trace there.

@endarova
Copy link
Contributor

endarova commented Aug 2, 2019 •
edited
Loading

preview tests to use --link option: Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@endarova endarova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@miroslavaivanova @endarova @dtopuzov @rosen-vladimirov