Disappearing icons from favorites list

[syphyr]

Describe the bug
If I slide my finger on any one of the icons in the favorites list a few times, eventually the icon will disappear and leave a space where it used to exist.

To Reproduce
Steps to reproduce the behavior:

1. Enable favorites list
2. Slide finger on icon, without actually selecting it (this may take several times before the icon disappears)

Expected behavior
Icon does not disappear when sliding finger over it

Screenshots
Please add screenshots to help explain your problem. You can upload images directly to Github, please do not use an external website to host your images.

Additional information

• App version: v3.20.1-35-g4a7d16e9
• App installed via: (f-droid, Play Store, debug APK): self built

Additional context
Logcat show the following error when the problem occurs:
E WindowManager: Unable to transfer touch focus

[syphyr]

This question on stackoverflow is exactly what is happeing when the icon disappears:
https://stackoverflow.com/questions/38866108/android-windowmanager-unable-to-transfer-touch-focus

[syphyr]

Also, I'm not sure if this is related, but I just started seeing this issue after the following commit:
852ead8 (6 days ago) (6 days ago) cancel loading pojos (marunjar)

Edit: Nevermind, I was still able to reproduce the problem without this commit.

[syphyr]

This is the relative android source that is reached when the favorites icon disappears:
https://android.googlesource.com/platform/frameworks/base/+/refs/tags/android-7.1.2_r39/services/core/java/com/android/server/wm/Session.java#339

Edit: On Android 7 the relative code is in Session.java and is later moved into WindowManagerService.java on newer versions of Android.

[syphyr]

Since this issue can be difficult to reproduce, perhaps it has something to do with LONG_PRESS_DELAY or MOVE_SENSITIVITY

KISS/app/src/main/java/fr/neamar/kiss/forwarder/Favorites.java

Line 236 in 4a7d16e

final int LONG_PRESS_DELAY = 250;

KISS/app/src/main/java/fr/neamar/kiss/forwarder/Favorites.java

Line 257 in 4a7d16e

int MOVE_SENSITIVITY = 8;

[syphyr]

So far, I am no longer able to reproduce the problem with the following change:
syphyr@b048d53

Perhaps the LONG_PRESS_DELAY should be increased even more than 500ms.

[syphyr]

After reading the Android documentation, the default long press settings are 400ms, 1000ms, and 1500ms.
https://android.googlesource.com/platform/packages/apps/Settings.git/+/master/res/values/arrays.xml#768

I think to be absolutely safe, the middle setting of 1000ms would be best.

syphyr@bd5b899

[marunjar]

After reading the Android documentation, the default long press settings are 400ms, 1000ms, and 1500ms. https://android.googlesource.com/platform/packages/apps/Settings.git/+/master/res/values/arrays.xml#768

I think to be absolutely safe, the middle setting of 1000ms would be best.

syphyr@bd5b899

Nice finding.

If there is a setting, why not use value from settings instead of fixed value?
https://developer.android.com/reference/android/view/ViewConfiguration#getLongPressTimeout()

[syphyr]

Great Idea! Thank you for the suggestion. Fixed.