Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming BurnResult -> WithdrawResult #59

Open
olga24912 opened this issue May 9, 2023 · 1 comment
Open

Renaming BurnResult -> WithdrawResult #59

olga24912 opened this issue May 9, 2023 · 1 comment

Comments

@olga24912
Copy link
Contributor

I propose to rename the BurnResult(https://github.com/aurora-is-near/eth-connector/blob/master/eth-custodian/contracts/EthCustodian.sol#L117) into WithdrawResult to be consistent with https://github.com/aurora-is-near/aurora-eth-connector/blob/master/eth-connector/src/lib.rs#L504
@sept-en
Copy link
Contributor

sept-en commented May 9, 2023

@olga24912 the deployed EthCustodian is not a proxy, thus non-modifiable (without extra process of the migration). It's also important to emphasize that we are verifying the proof of burning the tokens on the NEAR side; that's why it's BurnResult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sept-en @olga24912