Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC20Locker: unnecessary usage of SafeMath #161

Open
sept-en opened this issue Sep 7, 2022 · 0 comments
Open

ERC20Locker: unnecessary usage of SafeMath #161

sept-en opened this issue Sep 7, 2022 · 0 comments
Assignees
@sept-en
Labels
enhancement New feature or request P3 solidity

Comments

@sept-en
Copy link
Contributor

sept-en commented Sep 7, 2022

ERC20Locker used to be compiled with Solidity 0.6.12, so it needed to use SafeMath dependency. Currently, the contract code base utilizes Solidity 0.8.x, which has built in support of overflow and underflow warnings. Thus SafeMath library can be omitted for gas savings and code simplification.
@sept-en sept-en added enhancement New feature or request P3 solidity labels Sep 7, 2022
@sept-en sept-en self-assigned this Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sept-en sept-en

Labels
enhancement New feature or request P3 solidity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sept-en