Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User's settings #15

Open
clownishthorn opened this issue Feb 29, 2024 · 0 comments
Open

User's settings #15

clownishthorn opened this issue Feb 29, 2024 · 0 comments

Comments

@clownishthorn
Copy link

Should probably extend CurrentUserSerializer instead of BasicUserSerializer to prevent leakage of user's settings (nearataTwoFactorCanEnable, nearataTwoFactorAppEnabled) to others via app.forum.store.data.users

flarum-ext-twofactor/extend.php

Line 42 in 7525ccd

(new Extend\ApiSerializer(BasicUserSerializer::class))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clownishthorn