Support c_str() for compatibility with legacy C-Style APIs

[shreyasbharath]

Imagine a scenario like the below test. Because magic_enum returns a string_view, it is not compatible with C-style APIs.

Can we do anything to support legacy C-style code? The below code will result in a read buffer overflow as it'll keep reading past the end of the string until it hits a null terminator.

TEST("Read buffer overflow bug")
{
    enum class TestEnum
    {
        MODE_1,
        MODE_2
    };

    TestEnum test = TestEnum::MODE_2;
    auto name = magic_enum::enum_name(test);
    printf("%s", name.data());
}

[Neargye]

Hi @shreyasbharath, update in master.
Now example code is work ok.

[shreyasbharath]

Wow @Neargye thank you for the quick fix/response.

Can you also please add some tests/documentation on how to use? Can we create an overloaded function that returns a const char*? Thanks.

[Neargye]

I would not want to add a bunch of overloads. Now the library stores zero terminated string, so taking a string through the data() will work correctly.

[Neargye]

add some notices to doc

[shreyasbharath]

Thanks again 🎉