Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow capital letters in restart file names #341

Closed
aprilnovak opened this issue Jul 8, 2021 · 4 comments
Closed

Allow capital letters in restart file names #341

aprilnovak opened this issue Jul 8, 2021 · 4 comments

Comments

@aprilnovak
Copy link
Contributor

If you try to use a restart file with a capital letter (like Re1000.fld), nekRS throws an unhelpful abort message:

 Reading checkpoint data
/home/anovak/problems/msm_sfr_7pin/re1000.fld
byte_read() :: fopen failure2!
ERROR: Error reading restart header in mfi_prepare  ierr=  1

Describe the solution you'd like
NekRS should either print a useful error message that makes it clear that the source of the error is capitalization (and not any of the contents of the restart file itself), or else allow files with capital letters.

@emerzari
Copy link

emerzari commented Jul 8, 2021 via email

@yslan
Copy link
Contributor

yslan commented Jul 8, 2021

The capital letter is supported if you use double quotation.

restartFrom = "Re1000.fld"   # This reads Re1000.fld
restartFrom = Re1000.fld     # This reads re1000.fld

@emerzari
Copy link

emerzari commented Jul 8, 2021 via email

@stgeke
Copy link
Collaborator

stgeke commented Jul 9, 2021

Key/value pairs in par are case insensitive unless you use "value".
Printing a warning that the restart file has a capital letter doesn't make sense too me. However we should improve the error message that the file was not found instead of "ERROR: Error reading restart header in mfi_prepare". However that's something in nek5000.

We could also make it mandatory to put the restart file name in quotes. However this will break existing par files.

@stgeke stgeke closed this as completed Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants