Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More things we should perhaps rename #1278

Open
5 of 20 tasks
fingolfin opened this issue Feb 26, 2023 · 6 comments
Open
5 of 20 tasks

More things we should perhaps rename #1278

fingolfin opened this issue Feb 26, 2023 · 6 comments

Comments

@fingolfin
Copy link
Member

fingolfin commented Feb 26, 2023

Types:

  • SeriesElem -> SeriesRingElem or PowerSeriesRingElem
  • SeriesRing -> PowerSeriesRing
  • MSeriesElem -> MSeriesRingElem or ...
  • AbsMSeriesElem -> ...
  • SparsePolynomialRing -> sparse_polynomial_ring (but retain the type Generic.SparsePolynomialRing)
  • PuiseuxSeriesRing -> puiseux_series_ring
  • PuiseuxSeriesField -> puiseux_series_field
  • LaurentPolynomialRing -> laurent_polynomial_ring
  • FunctionField -> function_field
  • RationalFunctionField -> rational_function_field
  • FactoredFractionField ->
  • ResElem -> ResRingElem
  • FracElem -> FracFieldElem

Functions:

  • abs_series -> abs_power_series or absolute_power_series
  • abs_series_type -> ...
  • rel_series -> ...
  • rel_series_type -> ...
  • gens -> generators
  • ngens -> number_of_generators
  • rels -> relators
@thofma
Copy link
Member

thofma commented Feb 27, 2023

Do we need to rename abs_series_type? The *_type functions are more internal in nature.

@fingolfin
Copy link
Member Author

We don't need to, I just want us to make a conscious decision either way.

@fingolfin
Copy link
Member Author

Another one: MatrixAlgebra -> matrix_algebra ... or maybe full_matrix_algebra? Because that's what it is, while to me "matrix algebra" might also refer to any subalgebra thereof.

@thofma
Copy link
Member

thofma commented Mar 31, 2023

Since we have proper matrix algebras in Hecke, I will probably change everything so that the AA one will not be visible downstream anymore.

@fingolfin
Copy link
Member Author

Great!

@lgoettgens
Copy link
Collaborator

I think we once discussed about renaming Ring and NCRing to CommRing and Ring, but don't remember the result of that. If we actually want to go on with that, we should before Oscar 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants