Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concretize the generic interface for AbstractAlgebra #785

Closed
albinahlback opened this issue Mar 11, 2021 · 4 comments · Fixed by #887
Closed

Concretize the generic interface for AbstractAlgebra #785

albinahlback opened this issue Mar 11, 2021 · 4 comments · Fixed by #887

Comments

@albinahlback
Copy link
Contributor

I think the generic interface in AbstractAlgebra should be concretized and distinguished from specific types-interface.

#782 I think suggests changes in the right direction.

@thofma
Copy link
Member

thofma commented Mar 11, 2021

Yes, fully agree. I think it would make sense to first discuss how the folder structure should be before doing more work in this direction.

@wbhart made in #782 already some suggestions for the organization of the splitting:

[Aside: I guess we will eventually change the current generic directory to be called generic_structures or something similar, so generic_algorithms seems like a reasonable name for the directory for all the stuff you are moving. Edit: currently it seems to be called algorithms, so maybe we end up with "structures" and "algorithms" or similar. Edit: Edit: maybe we even end up with "algorithms" and "structures" inside a single "generic" directory.]

I personally would prefer if the directory for the "algorithms" would end up at the top level in src/. But I have no strong opinion. We just need to make a decision.

@wbhart
Copy link
Contributor

wbhart commented Mar 11, 2021

I have no strong preference, so long as both dirs are named clearly.

@albinahlback
Copy link
Contributor Author

I think it would make sense to first discuss how the folder structure should be before doing more work in this direction.
[...]
I personally would prefer if the directory for the "algorithms" would end up at the top level in src/. But I have no strong opinion. We just need to make a decision.

I think that would be a good decision. I would prefer the generic interface of AA to be "directly visible" from src/, i.e. not hidden under algorithms/.

@wbhart
Copy link
Contributor

wbhart commented May 31, 2021

I began splitting the abstract and generic stuff here #887

I decided to put the algorithms stuff at the top level src directory and the generic types stuff in generic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants