Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize prod_diagonal default method #1864

Open
fingolfin opened this issue Sep 24, 2024 · 1 comment
Open

Optimize prod_diagonal default method #1864

fingolfin opened this issue Sep 24, 2024 · 1 comment

Comments

@fingolfin
Copy link
Member

With some minor modifications it should be possible to turn prod_diagonal(A::ZZMatrix) into the new generic method, replacing the current generic method.

@fieker
Copy link
Contributor

fieker commented Dec 4, 2024

both are sub-optimal: the ZZMatrix function is more GC-friendly, but uses a slow algo for actually computing the product. The generic function copies the diagonal elements into a julia list (GC-bad), but then calls an asymptotically fast version to compute prod....
Ideally the Hecke ProdEnv should be used for large matrices, but I am not sure I have applications where the matrices are large enough and dense so that this matters...
For FqDefault the generics are terrible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants