Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing dependency on Pkg #1895

Closed
sumiya11 opened this issue Oct 13, 2024 · 0 comments · Fixed by #1964
Closed

Consider removing dependency on Pkg #1895

sumiya11 opened this issue Oct 13, 2024 · 0 comments · Fixed by #1964

Comments

@sumiya11
Copy link
Contributor

On Julia 1.11+, loading Pkg might not be free anymore :

julia> @time_imports using Nemo
    ...
    586.6 ms  Pkg
    ...

Welcome to Nemo version 0.45.7

Nemo comes with absolutely no warranty whatsoever
               ┌ 487.9 ms Nemo.__init__() 9.25% compilation time
    749.8 ms  Nemo 6.02% compilation time

It seems that Pkg is used for determining the version of Nemo :

const deps = Pkg.dependencies()

Maybe Base.get_pkgversion_from_path or similar can be used as a cheaper replacement :

julia> Base.get_pkgversion_from_path("../Nemo.jl/")
v"0.38.2"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant