-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove global Flint*
objects
#1935
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1935 +/- ##
==========================================
- Coverage 87.98% 87.96% -0.02%
==========================================
Files 99 99
Lines 36458 36458
==========================================
- Hits 32076 32070 -6
- Misses 4382 4388 +6 ☔ View full report in Codecov by Sentry. |
Triage decided (ref oscar-system/Oscar.jl#1379 (comment)) to first replace all uses of these downstream, then wait for some time, and only then merge this. If we need deprecations or not may be discussed then. |
can we keep the definitions but not export them? they are kind of handy |
the gaussian ones or the QQ/ZZ? And what is the benefit of e.g. |
The Gaussian ones |
We could just add |
also works for me |
As a milder step I would suggest that as a milder change we instead (or at first) modify Oscar and/or Hecke to not import resp. not re-export these. That would then perhaps be "breaking" for Oscar and/or Hecke but not Nemo, which arguably affects fewer people... But I am open to this PR here as well shrug |
312639d
to
89fe103
Compare
@thofma just approved via slack |
As suggested by @fieker in oscar-system/Oscar.jl#1379 (comment).
I would consider this a breaking change for Nemo, and this possibly needs some changes downstream in Hecke and Oscar for uses of
FlintZZ
andFlintQQ
.