Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dem_mosaic --priority-blending-length blends where there is no need for it #241

Open
oleg-alexandrov opened this issue Mar 8, 2019 · 1 comment

Comments

@oleg-alexandrov
Copy link
Member

If there is a DEM that is fully valid everywhere in its domain except for a little hole in the center where data is missing, and one attempts there to blend with another DEM using --priority-blending-length, the blending should happen only there. Yet, apparently, the DEM edge (pixel row row and col are either 0 or image size) is also treated as a place where there is no data because it can't see further pixels and blending is attempted there too. I think this comes from the fact that the weights we use naively decay to zero each time one does not see in all directions from a given pixel, and the true image boundary (as opposed to the image continuing but with no data in those pixels) needs to get special handling.

The testcase is on lunokhod1 in /home/oalexan1/projects/dem_mosaic_blending.

@ScottMcMichael
Copy link
Contributor

I added an option in 4a8c57b that mostly stops border blending but it looks like there is still some unnecessary blending going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants