Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: Make top of box "flat" #3

Open
bkgoodman opened this issue Mar 15, 2018 · 3 comments
Open

Patch: Make top of box "flat" #3

bkgoodman opened this issue Mar 15, 2018 · 3 comments

Comments

@bkgoodman
Copy link

Couldn't figure out how to do a pull request (sorry). Here is the patch (enclosed in zip). It works with "corners". It requires that the sides be "separated" when drawn, as if there was no kerf. So I changed the logic to "separate" pieces from always checking "self.kerf > 0.0" to "self.separate" - which is set if kerf >0.0 OR if you are drawing with a flat top.

(Option is under "misc")
flattop.zip

@Neon22
Copy link
Owner

Neon22 commented Aug 17, 2020

pretty interesting. Just got 1.0 migrated.
Looking into this now. thanks.

@Neon22
Copy link
Owner

Neon22 commented Aug 18, 2020

Working through this and made self.separate but you also refer to a topside variable and not sure how that's made.
Is it poss to send entire Lasercut_box.py file. I can do the diff here easily in notepad++.

@Neon22
Copy link
Owner

Neon22 commented Sep 10, 2020

I'm working on incorporating this and a fitted lid right now. Thanks for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants