feat: migrate from tslint to eslint. #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aorinevo
commented
Jul 21, 2020
aorinevo
commented
Jul 21, 2020
| @@ -19,7 +19,7 @@ export default async ( | |||
| context: IMigrationContext, | |||
| repo: IRepo, | |||
| phase: string, | |||
| showOutput: boolean = true, | |||
| showOutput = true, | |||
There was a problem hiding this comment.
This change was made via eslint autofix.
parshap
approved these changes
Jul 21, 2020
There was a problem hiding this comment.
Looks good to me, but wondering if @nwalters512 has any input as he's much more familiar with TS tooling than me.
aorinevo
force-pushed
the
tslint-to-eslint
branch
from
82fe6e9 to
5cb6e65
Compare
aorinevo
force-pushed
the
tslint-to-eslint
branch
from
d0d78fa to
d80fedf
Compare
aorinevo
pushed a commit
that referenced
this pull request
Aug 14, 2020
# [1.10.0](v1.9.4...v1.10.0) (2020-08-14) ### Features * migrate from tslint to eslint. ([#214](#214)) ([866eeae](866eeae))
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
jugaltheshah
pushed a commit
to jugaltheshah/shepherd
that referenced
this pull request
Jan 21, 2021
* feat: migrate from tslint to eslint. * chore: package-lock maintenance.
jugaltheshah
pushed a commit
to jugaltheshah/shepherd
that referenced
this pull request
Jan 21, 2021
# [1.10.0](NerdWalletOSS/shepherd@v1.9.4...v1.10.0) (2020-08-14) ### Features * migrate from tslint to eslint. ([NerdWalletOSS#214](NerdWalletOSS#214)) ([866eeae](NerdWalletOSS@866eeae))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Notes