Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop deprecated silent() from simple-git #445

Merged
merged 3 commits into from
Mar 8, 2021

Conversation

nwalters512
Copy link
Collaborator

Recent versions of simple-git deprecated the .silent() API, which now spams the console with a deprecation notice whenever it's used:

simple-git deprecation notice: git.silent: logging should be configured using the `debug` library / `DEBUG` environment variable, this will be an error in version 3

This PR drops the use of that API. The logger is now silent by default, which is the behavior we want.

@nwalters512 nwalters512 merged commit 8ce510e into master Mar 8, 2021
@nwalters512 nwalters512 deleted the fix/simple-git-silent branch March 8, 2021 21:55
aorinevo pushed a commit that referenced this pull request Mar 8, 2021
## [1.14.1](v1.14.0...v1.14.1) (2021-03-08)

### Bug Fixes

* drop deprecated silent() from simple-git ([#445](#445)) ([8ce510e](8ce510e))
@aorinevo
Copy link
Collaborator

aorinevo commented Mar 8, 2021

🎉 This PR is included in version 1.14.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants