Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use custom GitHub token to bypass branch protection #565

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

nwalters512
Copy link
Collaborator

Our few most recent commits to master have failed to publish because semantic-release couldn't push new versions to master. Per https://github.com/semantic-release/semantic-release/blob/8fda7fd423d24e7b425fbee83790f49dd0478e2d/docs/recipes/ci-configurations/github-actions.md#pushing-packagejson-changes-to-a-master-branch, we should be setting persist-credentials: false during checkout so that our custom token (that can bypass branch protection restrictions) is used by semantic-release.

@nwalters512 nwalters512 requested a review from aorinevo December 2, 2021 20:25
@nwalters512 nwalters512 merged commit 2c17503 into master Dec 3, 2021
@nwalters512 nwalters512 deleted the fix/github-actions-release branch December 3, 2021 17:58
aorinevo pushed a commit that referenced this pull request Dec 3, 2021
# [1.16.0](v1.15.5...v1.16.0) (2021-12-03)

### Bug Fixes

* Use custom GitHub token to bypass branch protection ([#565](#565)) ([2c17503](2c17503))

### Features

* Exclude archived repos when using code search ([#564](#564)) ([ec4fa27](ec4fa27))
* GitHub request throttling ([#551](#551)) ([b93d30e](b93d30e))
@nwalters512
Copy link
Collaborator Author

Looks like this worked - v1.16.0 was just published!

@aorinevo
Copy link
Collaborator

aorinevo commented Dec 3, 2021

🎉 This PR is included in version 1.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants