Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow migration config to be overriden by command line options #91

Open
parshap opened this issue Dec 9, 2019 · 0 comments
Open

Allow migration config to be overriden by command line options #91

parshap opened this issue Dec 9, 2019 · 0 comments
Assignees
Labels
needs discussion Needs more discussion to determine what to do

Comments

@parshap
Copy link
Contributor

parshap commented Dec 9, 2019

Migration configuration specified in shepherd.yml should be overridable by command line options. This helps make migrations more reusable. For example, you could specify --adapter.search_query "org:nerdwallet filename:package.json react" to run a migration but with a different GitHub search query.

Notes:

  • Some parts of shepherd.yml probably make less sense to be configurable by the command line, but for sake of flexibility and simplicity of implementation, we should probably just allow all keys to be overridable.
  • Before/after "hooks" would probably be useful to run commands before or after the commands specified by the migration (e.g., --hooks.should_migrate.before "$(git show -s --format=%ct HEAD) <= $(date -d 'now - 100 days' +%s))".
@parshap parshap added the needs discussion Needs more discussion to determine what to do label Dec 9, 2019
@aorinevo aorinevo self-assigned this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion Needs more discussion to determine what to do
Projects
None yet
Development

No branches or pull requests

2 participants