Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): h5端image组件缩放方式使用css实现 #6205

Closed
wants to merge 1 commit into from
Closed

fix(components): h5端image组件缩放方式使用css实现 #6205

wants to merge 1 commit into from

Conversation

myl0204
Copy link
Contributor

@myl0204 myl0204 commented May 4, 2020

这个 PR 做了什么? (简要描述所做更改)
h5端，mode实现部分的代码重构，我之前的实现代码不是很优雅，同时也带来了额外一次setState。 这次改用css方式，使用object-fit实现

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用，不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

其它需要 Reviewer 或社区知晓的内容：

@luckyadam
Copy link
Member

object-fit 会不会兼容性略低
https://caniuse.com/#search=object-fit

@myl0204
Copy link
Contributor Author

myl0204 commented May 6, 2020

object-fit 会不会兼容性略低
https://caniuse.com/#search=object-fit

95.62%我觉得完全ojbk了吧，移动端支持度比这个还要高一些

@taro-bot taro-bot bot mentioned this pull request May 9, 2020
Closed
@myl0204
Copy link
Contributor Author

myl0204 commented May 13, 2020

移动端 Vue 组件库Vant也是采取这种方式 detail

@shenghanqin
Copy link
Collaborator

@myl0204 object-fit，其实效果并没有微信小程序版本实现的效果好。比如说，contain时，宽度够了、高度不够的情况，图片效果也不理想的。

@luckyadam luckyadam force-pushed the 2.x branch 2 times, most recently from 0fff737 to 4723704 Compare July 9, 2020 07:12
@taro-bot2 taro-bot2 bot mentioned this pull request Jul 11, 2020
Closed
@Chen-jj Chen-jj added A-components Area - H5 组件库相关 V-2 Version - 2.x labels Jul 16, 2020
@ZakaryCode ZakaryCode self-requested a review July 31, 2020 03:07
ZakaryCode
ZakaryCode reviewed Jul 31, 2020
View reviewed changes
Copy link
Contributor

@ZakaryCode ZakaryCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢贡献，不过提交冲突，将在另一个 PR 合并

@ZakaryCode ZakaryCode mentioned this pull request Jul 31, 2020
Merged
20 tasks
@ZakaryCode ZakaryCode closed this Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZakaryCode ZakaryCode ZakaryCode left review comments

Assignees
No one assigned
Labels
A-components Area - H5 组件库相关 V-2 Version - 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@myl0204 @luckyadam @shenghanqin @ZakaryCode @Chen-jj