Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"WARNING: unrecognised option [--peptidoforms]" #1826

Closed
Shinya-Watanabe opened this issue Oct 14, 2024 · 10 comments
Closed

"WARNING: unrecognised option [--peptidoforms]" #1826

Shinya-Watanabe opened this issue Oct 14, 2024 · 10 comments
Assignees

Comments

@Shinya-Watanabe
Copy link

Hi Fengchao,
I wanted to run DIA-NN with "--peptidoforms" function, but it seems like it did not recognized the function.

log_2024-10-14_10-24-29.txt

Following #1815, I am still trying to get PTM localization probability using the combination of DIA-NN and FragPipe, which protein c-terminal modification seem the issue not only in PTMProphet but also DIA-NN. I have been discussing this with Vadim on vdemichev/DiaNN#1207. If you have any thoughts on this, it would helpful.

Best,
Shinya

@fcyu
Copy link
Member

fcyu commented Oct 14, 2024

You need to specify DIA-NN 1.9.1 in FragPipe.

Best,

Fengchao

@fcyu fcyu self-assigned this Oct 14, 2024
@Shinya-Watanabe
Copy link
Author

I got an error ERROR: D:\diann\src\diann.cpp: 4064: unknown modification: UniMod:734, which I did not get in the previous version with the same search.
log_2024-10-14_12-01-22.txt

Also, I have unknown modifications for myself, such as 202.05896 and 216.07462. These are also in library.tsv but I do not have any modifications with these mass in MSFragger.
WARNING: below are the unknown modifications found in the library. While unlikely to have a signficant effect, these might negatively affect identification performance in certain scenarious, it is strongly recommended to declare them using any of --mod, --fixed-mod or --var-mod: 202.05896, 216.07462, 87.026746, UniMod:734

Best,
Shinya

@fcyu
Copy link
Member

fcyu commented Oct 14, 2024

I got an error ERROR: D:\diann\src\diann.cpp: 4064: unknown modification: UniMod:734, which I did not get in the previous version with the same search.

You need to declare them in DIA-NN https://github.com/vdemichev/DiaNN?tab=readme-ov-file#command-line-reference

Also, I have unknown modifications for myself, such as 202.05896 and 216.07462. These are also in library.tsv but I do not have any modifications with these mass in MSFragger.

They are the modification mass + amino acid mass.

Best,

Fengchao

@Shinya-Watanabe
Copy link
Author

I did declare --var-mod PS,87.03203,DE --var-mod PE,43.0422,DE. However, DIA-NN does not have function to specify protein c-terminus. Do I need to declare these two as well, 202.05896 and 216.07462?

This modification ERROR: D:\diann\src\diann.cpp: 4064: unknown modification: UniMod:734 is already declared by --var-mod PE,43.0422,DE.

@fcyu
Copy link
Member

fcyu commented Oct 14, 2024

I did declare --var-mod PS,87.03203,DE --var-mod PE,43.0422,DE

This modification ERROR: D:\diann\src\diann.cpp: 4064: unknown modification: UniMod:734 is already declared by --var-mod PE,43.0422,DE.

The mass should be modification mass+amino acid mass if they were not recognized as UniMod

However, DIA-NN does not have function to specify protein c-terminus. Do I need to declare these two as well, 202.05896 and 216.07462?

Then, you won't be able to use the "--peptidoforms" function.

Best,

Fengchao

@Shinya-Watanabe
Copy link
Author

Why does UniMod:734 has the unknown modification error? This is a modification listed in UniMod, so it should be known modification, isn't it?

Best,
Shinya

@Shinya-Watanabe
Copy link
Author

I figured this out. The spectral library generated by FragPipe annotates modifications provided in MSFragger as either UniMod accession number or the modification mass. Thus, "cmd line opts" has to use either of them, for example, --mod 216.07462,216.07462. However, I still did not get modification localization columns such as STY:79.96633 Best Localization in report.pr_matrix.tsv. When I used "DIA_SpecLib_Quant_Phospho_diaPASEF" workflow, I have those columns. Is this due to disabling PTMProphet?

Best,
Shinya

@fcyu
Copy link
Member

fcyu commented Oct 14, 2024

Is this due to disabling PTMProphet?

Yes

Best,

Fengchao

@Shinya-Watanabe
Copy link
Author

Thank you! I hope PTMProphet team fixes Protein c-terminal modification error soon.

Best,
Shinya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants