Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you provide an update to Angular 9? #12

Open
Svitra opened this issue Apr 6, 2020 · 1 comment
Open

Could you provide an update to Angular 9? #12

Svitra opened this issue Apr 6, 2020 · 1 comment

Comments

@Svitra
Copy link

Svitra commented Apr 6, 2020

Could you provide an update to Angular 9 - now with npm I am getting warnings about required peer dependencies of Angular common and core 4.0, I am also getting errors when trying to render the component in the upgraded components (worked fine for Angular 8).

@Svitra
Copy link
Author

Svitra commented Apr 16, 2020

For the problems I observed I think it would be enoguh if you changed the ViewChild definifions to be static:

  /** The native select element */
  @ViewChild('selectElement', { static: true }) select: ElementRef;

  /** The native input element */
  @ViewChild('textElement', { static: true }) textElement: ElementRef;
  

Should I open a pull request for this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant