Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TotalExecutionTime not tracked on queue() #20

Closed
benjchristensen opened this issue Nov 29, 2012 · 1 comment
Closed

TotalExecutionTime not tracked on queue() #20

benjchristensen opened this issue Nov 29, 2012 · 1 comment
Labels
Milestone

Comments

@benjchristensen
Copy link
Contributor

The TotalExecutionTime is tracked on execute() but not on queue().

This is not a problem with the normal executionTime metric around the run() method, but the total end-to-end metric.

For queue() we want to track from the time queue() is invoked until the time the underlying thread completes and a Future.get() could retrieve the value even if it doesn't.

We don't want to track until Future.get() is invoked as that is not the actual processing time of the execution and can be variant depending on what the client code is doing.

This was a known missing feature but I'm marking this as a bug as it should have been there before marking the 1.0 release.

@benjchristensen
Copy link
Contributor Author

Implemented in 1.1.7

Here is a screenshot showing before (green) and after (red) on a command that is only executed asynchronously so previously did not capture TotalExecutionTime but now does.

Screen Shot 2012-12-21 at 7 34 43 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant