Hystrix.reset() doesn't reset default command properties

[adamdyga]

Hystrix version: 1.4.0-RC4
The documentation of com.netflix.hystrix.HystrixCommand#HystrixCommand(com.netflix.hystrix.HystrixCommand.Setter) says:

"Properties passed in via Setter#andCommandPropertiesDefaults or Setter#andThreadPoolPropertiesDefaults are cached for the given HystrixCommandKey for the life of the JVM or until Hystrix#reset() is called."

Unfortunately calling Hystrix.reset() doesn't reset all propery defaults, and , in particular executionIsolationThreadTimeoutInMilliseconds set for instance this way:

protected MyCommand(final int timeout)
{
   super(Setter.withGroupKey(COMMAND_GROUP).andCommandPropertiesDefaults(HystrixCommandProperties.Setter()
             .withExecutionIsolationThreadTimeoutInMilliseconds(timeout)));

}

Because of this either the documention or Hystrix.reset() should be corrected. It would be nice, however, if Hystrix.reset() really resets the timeouts. This may be useful in (unit) tests.

[Randgalt]

+1

[pascal-warnimont]

+1
use case:

• unit test use short time out ( order of 10 seconds)
• it and integration use actual service timeout ( order of 1000 ms)