Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onFallbackStart/onFallbackError hooks invoked when fallback not defined #519

Closed
mattrjacobs opened this issue Jan 16, 2015 · 2 comments
Closed

onFallbackStart/onFallbackError hooks invoked when fallback not defined #519

mattrjacobs opened this issue Jan 16, 2015 · 2 comments

Comments

@mattrjacobs
Copy link
Contributor

Found this while investigating #509. This wasn't expected to me. It arises because the getFallback() method is invoked, and these hooks are getting invoked even in the UnsupportedOperationException case.
@mattrjacobs mattrjacobs added this to the 1.4.0-RC6 milestone Jan 17, 2015
@mattrjacobs
Copy link
Contributor Author

I think we would need a reflection-like strategy (as demonstrated in #529) to accomplish this. Other than reflection, I don't know a way to determine if a user has supplied a getFallback() implementation. This doesn't like an important enough issue to warrant this change. I'll put this issue on the backlog and possibly pick it back up later.

@mattrjacobs mattrjacobs removed this from the 1.4.0-RC6 milestone Jan 19, 2015
@mattrjacobs mattrjacobs modified the milestone: 1.4.2 Mar 3, 2015
@mattrjacobs mattrjacobs modified the milestones: Hystrix-core Features, Hystrix-core Bugfixes Mar 27, 2015
@mattrjacobs mattrjacobs mentioned this issue Apr 13, 2015
Merged
@mattrjacobs
Copy link
Contributor Author

Fixed in #754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattrjacobs