Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hystrix Dashboard is not showing up Rejected count #574

Closed
ramkarna opened this issue Jan 27, 2015 · 9 comments · Fixed by #728
Closed

Hystrix Dashboard is not showing up Rejected count #574

ramkarna opened this issue Jan 27, 2015 · 9 comments · Fixed by #728

Comments

@ramkarna
Copy link

Hi,
Hystrix Dashboard is not showing up rejected count, though the hystrix stream json response has rejected count. We are tried Hystrix Dashboard version hystrix-dashboard-1.3.18 and hystrix-dashboard-1.4.0-RC5. We tried deploying on Tomcat 8
untitled
and Liberty profile.
Hystrix Stream output:
{"type":"HystrixCommand","name":"operation","group":"WebService","currentTime":1422043075322,"isCircuitBreakerOpen":false,"errorPercentage":5,"errorCount":2,"requestCount":39,"rollingCountCollapsedRequests":0,"rollingCountExceptionsThrown":2,
"rollingCountFailure":0,"rollingCountFallbackFailure":0,"rollingCountFallbackRejection":0,"rollingCountFallbackSuccess":0,"rollingCountResponsesFromCache":0,"rollingCountSemaphoreRejected":2,"rollingCountShortCircuited":0,"rollingCountSuccess":37,"rollingCountThreadPoolRejected":0,"rollingCountTimeout":0,"currentConcurrentExecutionCount":0,"latencyExecute_mean":115,"latencyExecute":{"0":85,"25":106,"50":114,"75":124,"90":133,"95":138,"99":188,"99.5":190,"100":191},"latencyTotal_mean":116,"latencyTotal":{"0":85,"25":106,"50":115,"75":124,"90":133,"95":138,"99":188,"99.5":190,"100":191},"propertyValue_circuitBreakerRequestVolumeThreshold":20,"propertyValue_circuitBreakerSleepWindowInMilliseconds":5000,"propertyValue_circuitBreakerErrorThresholdPercentage":75,"propertyValue_circuitBreakerForceOpen":false,"propertyValue_circuitBreakerForceClosed":false,"propertyValue_circuitBreakerEnabled":true,"propertyValue_executionIsolationStrategy":"SEMAPHORE","propertyValue_executionIsolationThreadTimeoutInMilliseconds":1000,"propertyValue_executionIsolationThreadInterruptOnTimeout":true,"propertyValue_executionIsolationThreadPoolKeyOverride":null,"propertyValue_executionIsolationSemaphoreMaxConcurrentRequests":1,"propertyValue_fallbackIsolationSemaphoreMaxConcurrentRequests":1,"propertyValue_metricsRollingStatisticalWindowInMilliseconds":10000,"propertyValue_requestCacheEnabled":true,"propertyValue_requestLogEnabled":true,"reportingHosts":1}

Please let us know the solution if any.

@mattrjacobs
Copy link
Contributor

I'll take a look, @ramkarna

@dsukner
Copy link

dsukner commented Jan 29, 2015

Have the same problem. Is there a soution?

@mattrjacobs
Copy link
Contributor

@ramkarna / @dsukner I'm focusing on getting the command internals working before focusing on the dashboard. In all likelihood, I will try to get an RC out with just internal changes so that I can get testing started on that before I turn my attention to the dashboard. I'm happy to review any changes you make, though.

@mattrjacobs mattrjacobs added this to the 1.4.x milestone Feb 5, 2015
@ramkarna
Copy link
Author

ramkarna commented Feb 5, 2015

Is failure types like SHORTCIRCUIT, REJECTED_SEMAPHORE_EXECUTION are treating as an errors?

@ramkarna
Copy link
Author

In hystrixCircuit.html rejected count displaying only for THREAD strategy.
<% if(propertyValue_executionIsolationStrategy == 'THREAD') { %>
<%= addCommas(rollingCountTimeout) %>
<%= addCommas(rollingCountThreadPoolRejected) %>
<% } %>
If you add the below code then it will fix the issue and rejected count will show it up for SEMAPHORE
<% if(propertyValue_executionIsolationStrategy == 'SEMAPHORE') { %>
<%= addCommas(rollingCountSemaphoreRejected) %>
<% } %>

@mattrjacobs
Copy link
Contributor

Thanks for investigating, @ramkarna. Once I get around to the dashboard set of tasks, I'll include your change

@mattrjacobs
Copy link
Contributor

I believe this is fixed in #728. @ramkarna / @dsukner - Can you confirm this looks the way you expect?

@ramkarna
Copy link
Author

Sure will take a look at it and confirm.

@ramkarna
Copy link
Author

Fix is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants