Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tie HealthCounts to bucket-rolling for HystrixCommandMetrics #873

Closed
mattrjacobs opened this issue Aug 25, 2015 · 1 comment
Closed

Tie HealthCounts to bucket-rolling for HystrixCommandMetrics #873

mattrjacobs opened this issue Aug 25, 2015 · 1 comment
Labels
enhancement hystrix-core

Comments

@mattrjacobs
Copy link
Contributor

Currently, these run on 2 schedules which are disconnected. Is there a good reason not to consolidate these onto the same schedule? If we did so, there would be 1 less config option to care about, and there would be a better contract for any future extensions of HystrixCommandMetrics to uphold - that they can use any data structures/algorithms they would like, but they must provide a HealthCounts
@mattrjacobs mattrjacobs added this to the 1.5.x milestone Aug 25, 2015
@mattrjacobs
Copy link
Contributor Author

See #854 for more context

@mattrjacobs mattrjacobs removed this from the 1.5.x milestone Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement hystrix-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattrjacobs