Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sortable columns #2

Closed
jfernandez opened this issue Feb 15, 2024 · 4 comments
Closed

Sortable columns #2

jfernandez opened this issue Feb 15, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@jfernandez
Copy link
Contributor

jfernandez commented Feb 15, 2024 •
edited
Loading

bpftop should let you sort the entries by column, in ascending or descending order. This would require us to track the selected program by its ID rather than its index in the items vec.
@jfernandez jfernandez added the enhancement New feature or request label Feb 15, 2024
@tyrone-wu tyrone-wu mentioned this issue Mar 17, 2024
Merged
@tyrone-wu
Copy link
Contributor

Should the sort be applied to only a single column at a time, or would it be more useful to have each column track it's own sort state (asc/desc)?

@jfernandez
Copy link
Contributor Author

Only a single column at the time

@tyrone-wu
Copy link
Contributor

I just submitted a PR #26 for this feature that's ready for review. 🙂

@tyrone-wu tyrone-wu mentioned this issue Mar 23, 2024
Merged
@jfernandez
Copy link
Contributor Author

Merged! Thank you again for your contribution. I'm releasing v0.4.0 with this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfernandez @tyrone-wu